Eagerly detect double free and sized dealloc bugs for large sizes.

This commit is contained in:
Qi Wang
2020-10-14 16:45:19 -07:00
committed by Qi Wang
parent be9548f2be
commit 3de19ba401
7 changed files with 136 additions and 23 deletions

56
test/unit/double_free.c Normal file
View File

@@ -0,0 +1,56 @@
#include "test/jemalloc_test.h"
#include "jemalloc/internal/safety_check.h"
bool fake_abort_called;
void fake_abort(const char *message) {
(void)message;
fake_abort_called = true;
}
void
test_large_double_free_pre(void) {
safety_check_set_abort(&fake_abort);
fake_abort_called = false;
}
void
test_large_double_free_post() {
expect_b_eq(fake_abort_called, true, "Double-free check didn't fire.");
safety_check_set_abort(NULL);
}
TEST_BEGIN(test_large_double_free_tcache) {
test_skip_if(!config_opt_safety_checks);
/*
* Skip debug builds, since too many assertions will be triggered with
* double-free before hitting the one we are interested in.
*/
test_skip_if(config_debug);
test_large_double_free_pre();
char *ptr = malloc(SC_LARGE_MINCLASS);
free(ptr);
free(ptr);
mallctl("thread.tcache.flush", NULL, NULL, NULL, 0);
test_large_double_free_post();
}
TEST_END
TEST_BEGIN(test_large_double_free_no_tcache) {
test_skip_if(!config_opt_safety_checks);
test_skip_if(config_debug);
test_large_double_free_pre();
char *ptr = mallocx(SC_LARGE_MINCLASS, MALLOCX_TCACHE_NONE);
dallocx(ptr, MALLOCX_TCACHE_NONE);
dallocx(ptr, MALLOCX_TCACHE_NONE);
test_large_double_free_post();
}
TEST_END
int
main(void) {
return test(test_large_double_free_no_tcache,
test_large_double_free_tcache);
}