Eagerly detect double free and sized dealloc bugs for large sizes.

This commit is contained in:
Qi Wang
2020-10-14 16:45:19 -07:00
committed by Qi Wang
parent be9548f2be
commit 3de19ba401
7 changed files with 136 additions and 23 deletions

View File

@@ -8,48 +8,65 @@ void fake_abort(const char *message) {
fake_abort_called = true;
}
#define SIZE1 SC_SMALL_MAXCLASS
#define SIZE2 (SC_SMALL_MAXCLASS / 2)
#define SMALL_SIZE1 SC_SMALL_MAXCLASS
#define SMALL_SIZE2 (SC_SMALL_MAXCLASS / 2)
TEST_BEGIN(test_invalid_size_sdallocx) {
test_skip_if(!config_opt_size_checks);
#define LARGE_SIZE1 SC_LARGE_MINCLASS
#define LARGE_SIZE2 (LARGE_SIZE1 * 2)
void *
test_invalid_size_pre(size_t sz) {
safety_check_set_abort(&fake_abort);
fake_abort_called = false;
void *ptr = malloc(SIZE1);
void *ptr = malloc(sz);
assert_ptr_not_null(ptr, "Unexpected failure");
sdallocx(ptr, SIZE2, 0);
expect_true(fake_abort_called, "Safety check didn't fire");
return ptr;
}
void
test_invalid_size_post(void) {
expect_true(fake_abort_called, "Safety check didn't fire");
safety_check_set_abort(NULL);
}
TEST_BEGIN(test_invalid_size_sdallocx) {
test_skip_if(!config_opt_size_checks);
void *ptr = test_invalid_size_pre(SMALL_SIZE1);
sdallocx(ptr, SMALL_SIZE2, 0);
test_invalid_size_post();
ptr = test_invalid_size_pre(LARGE_SIZE1);
sdallocx(ptr, LARGE_SIZE2, 0);
test_invalid_size_post();
}
TEST_END
TEST_BEGIN(test_invalid_size_sdallocx_nonzero_flag) {
test_skip_if(!config_opt_size_checks);
safety_check_set_abort(&fake_abort);
fake_abort_called = false;
void *ptr = malloc(SIZE1);
assert_ptr_not_null(ptr, "Unexpected failure");
sdallocx(ptr, SIZE2, MALLOCX_TCACHE_NONE);
expect_true(fake_abort_called, "Safety check didn't fire");
void *ptr = test_invalid_size_pre(SMALL_SIZE1);
sdallocx(ptr, SMALL_SIZE2, MALLOCX_TCACHE_NONE);
test_invalid_size_post();
safety_check_set_abort(NULL);
ptr = test_invalid_size_pre(LARGE_SIZE1);
sdallocx(ptr, LARGE_SIZE2, MALLOCX_TCACHE_NONE);
test_invalid_size_post();
}
TEST_END
TEST_BEGIN(test_invalid_size_sdallocx_noflags) {
test_skip_if(!config_opt_size_checks);
safety_check_set_abort(&fake_abort);
fake_abort_called = false;
void *ptr = malloc(SIZE1);
assert_ptr_not_null(ptr, "Unexpected failure");
je_sdallocx_noflags(ptr, SIZE2);
expect_true(fake_abort_called, "Safety check didn't fire");
void *ptr = test_invalid_size_pre(SMALL_SIZE1);
je_sdallocx_noflags(ptr, SMALL_SIZE2);
test_invalid_size_post();
safety_check_set_abort(NULL);
ptr = test_invalid_size_pre(LARGE_SIZE1);
je_sdallocx_noflags(ptr, LARGE_SIZE2);
test_invalid_size_post();
}
TEST_END