lihao/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-07-24 13:53:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not dehugify when purging

Browse Source 
Giving the advice MADV_DONTNEED to a range of virtual memory backed by
a transparent huge page already causes that range of virtual memory to
become backed by regular pages.
This commit is contained in:
lexprfuncall
2025-08-04 14:43:03 -07:00
committed by Guangli Dai
parent 395e63bf7e
commit a156e997d7
6 changed files with 3 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/unit/hpa_vectorized_madvise.c
View File

@@ -123,12 +123,6 @@ defer_test_hugify(void *ptr, size_t size, bool sync) {
return false;
}
static size_t ndefer_dehugify_calls = 0;
static void
defer_test_dehugify(void *ptr, size_t size) {
++ndefer_dehugify_calls;
}
static nstime_t defer_curtime;
static void
defer_test_curtime(nstime_t *r_time, bool first_reading) {
@@ -148,7 +142,6 @@ TEST_BEGIN(test_vectorized_failure_fallback) {
hooks.unmap = &defer_test_unmap;
hooks.purge = &defer_test_purge;
hooks.hugify = &defer_test_hugify;
hooks.dehugify = &defer_test_dehugify;
hooks.curtime = &defer_test_curtime;
hooks.ms_since = &defer_test_ms_since;
hooks.vectorized_purge = &defer_vectorized_purge_fail;
@@ -188,7 +181,6 @@ TEST_BEGIN(test_more_regions_purged_from_one_page) {
hooks.unmap = &defer_test_unmap;
hooks.purge = &defer_test_purge;
hooks.hugify = &defer_test_hugify;
hooks.dehugify = &defer_test_dehugify;
hooks.curtime = &defer_test_curtime;
hooks.ms_since = &defer_test_ms_since;
hooks.vectorized_purge = &defer_vectorized_purge;
@@ -231,7 +223,6 @@ TEST_BEGIN(test_more_regions_purged_from_one_page) {
* we have dirty pages.
*/
expect_zu_eq(0, ndefer_hugify_calls, "Hugified too early");
expect_zu_eq(0, ndefer_dehugify_calls, "Dehugified too early");
/* We purge from 2 huge pages, each one 3 dirty continous segments.
* For opt_process_madvise_max_batch = 2, that is
@@ -259,7 +250,6 @@ TEST_BEGIN(test_more_pages_than_batch_page_size) {
hooks.unmap = &defer_test_unmap;
hooks.purge = &defer_test_purge;
hooks.hugify = &defer_test_hugify;
hooks.dehugify = &defer_test_dehugify;
hooks.curtime = &defer_test_curtime;
hooks.ms_since = &defer_test_ms_since;
hooks.vectorized_purge = &defer_vectorized_purge;
@@ -296,7 +286,6 @@ TEST_BEGIN(test_more_pages_than_batch_page_size) {
* we have dirty pages.
*/
expect_zu_eq(0, ndefer_hugify_calls, "Hugified too early");
expect_zu_eq(0, ndefer_dehugify_calls, "Dehugified too early");
/* We have page batch size = 1.
* we have 5 * HP active pages, 3 * HP dirty pages