lihao/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-07-22 04:03:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add TODO to benchmark possibly better policy

Browse Source
This commit is contained in:
Slobodan Predolac
2026-03-27 13:54:15 -07:00
parent 6281482c39
commit db7d99703d
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sec.c
View File

@@ -130,13 +130,17 @@ sec_multishard_trylock_alloc(
cur_shard = 0;
}
}
/* No bin had alloc or had the extent */
/*
* TODO: Benchmark whether it is worth blocking on all shards here before
* declaring a miss. That could recover more remote-shard hits under
* contention, but it also changes the allocation latency policy.
*/
assert(cur_shard == sec_shard_pick(tsdn, sec));
bin = sec_bin_pick(sec, cur_shard, pszind);
malloc_mutex_lock(tsdn, &bin->mtx);
edata_t *edata = sec_bin_alloc_locked(tsdn, sec, bin, size);
if (edata == NULL) {
/* Only now we know it is a miss */
/* Only now we know it is a miss. */
bin->stats.nmisses++;
}
malloc_mutex_unlock(tsdn, &bin->mtx);